https://github.com/steakhal approved this pull request.

I'm not opposing to this.
I think the way CTU is tested using these thousands of Input files is just some 
legacy because we didn't have `split-file` to actually have these input files 
in a single test file.

I also dislike the hard-coded USRs, and I think I'll claude something to make 
this prettier unless you say I shouldn't because you have forks/or downstream 
patches where such changes would interfere with. In that case I'd of course try 
not to mess with you.

I think it looks good, and we should welcome any error reporting improvements; 
so I'm personally looking forward to this. I had one minor inline comment 
though, that'd like to see addressed before landing.

https://github.com/llvm/llvm-project/pull/188524
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to