ChuanqiXu9 wrote: The test failure looks related. And the touched part is too fundamental, it is better to avoid touching it if possible.
The root problem here is the special lookup rules for unscoped enums (it is much better if we only have scoped enums). So maybe we can have some alternatives: 1. Add a field in EnumConstantDecl to indicate the visibility of the decl is promoted. So that we won't remove these promoted decls later. This semantics will be much cleaner. 2. Just not skipping parsing unscoped enums. This was an optimization that, if we import first and #include later, we can try to skip parsing some contents in #include. But given enums are trivial, it may not hurt if we don't skip parsing it. https://github.com/llvm/llvm-project/pull/188865 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
