banach-space wrote: > @banach-space , Do the recent changes I made seem reasonable or am I messed > this up?
It looks like you are heading in the right direction, but since you rebased and force-pushed, it is hard for me to see exactly what has changed. Sometimes a re-base is unavoidable, but please keep in mind that that effectively erases Git history and is discouraged: https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes In any case, thank you for working on this! I am about to post more comments :) https://github.com/llvm/llvm-project/pull/188190 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
