================ @@ -32,6 +32,12 @@ class SymbolReaper; /// This allows the environment to manage context-sensitive bindings, /// which is essentially for modeling recursive function analysis, among /// other things. +/// FIXME: Use 'Expr' instead of 'Stmt' because associating a result with a +/// non-expression statement does not make sense. Currently the environment +/// never contains non-expression statements; and there is only one +/// easy-to-eliminate hack in 'processCallExit' and 'Environment::getSVal' that +/// constructs and handles 'EnvironmentEntry' instances with a 'ReturnStmt' as +/// the 'first' part. ---------------- steakhal wrote:
I have a problem with this comment. It says it shouldn't do something, and we give rational. Then we say what should we do instead but it doesn't tell me why we didn't ended up doing what you present here. This means that I have a FIXME comment that I don't know how to act on; and will remain there indefinitely. https://github.com/llvm/llvm-project/pull/188319 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
