Author: Matt Arsenault Date: 2026-03-30T17:48:20Z New Revision: fedb525151561a0c96f74cd5d17677c2f546b5d6
URL: https://github.com/llvm/llvm-project/commit/fedb525151561a0c96f74cd5d17677c2f546b5d6 DIFF: https://github.com/llvm/llvm-project/commit/fedb525151561a0c96f74cd5d17677c2f546b5d6.diff LOG: clang: Remove unnecessary triple normalize in offloading job (#189435) These should already have been normalized (and the device side comes from code, which should have been trivially normalized to start). Added: Modified: clang/lib/Driver/ToolChains/Clang.cpp Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 86b0a705c7fe9..31240ef81d4ff 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -5027,19 +5027,18 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (IsCuda || IsHIP) { // We have to pass the triple of the host if compiling for a CUDA/HIP device // and vice-versa. - std::string NormalizedTriple; + StringRef TripleStr; if (JA.isDeviceOffloading(Action::OFK_Cuda) || JA.isDeviceOffloading(Action::OFK_HIP)) - NormalizedTriple = C.getSingleOffloadToolChain<Action::OFK_Host>() - ->getTriple() - .normalize(); + TripleStr = + C.getSingleOffloadToolChain<Action::OFK_Host>()->getTriple().str(); else { // Host-side compilation. - NormalizedTriple = + TripleStr = (IsCuda ? C.getOffloadToolChains(Action::OFK_Cuda).first->second : C.getOffloadToolChains(Action::OFK_HIP).first->second) ->getTriple() - .normalize(); + .str(); if (IsCuda) { // We need to figure out which CUDA version we're compiling for, as that // determines how we load and launch GPU kernels. @@ -5053,7 +5052,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, } } CmdArgs.push_back("-aux-triple"); - CmdArgs.push_back(Args.MakeArgString(NormalizedTriple)); + CmdArgs.push_back(Args.MakeArgString(TripleStr)); if (JA.isDeviceOffloading(Action::OFK_HIP) && (getToolChain().getTriple().isAMDGPU() || _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
