================

----------------
jh7370 wrote:

We should check the lower-level message too (i.e. the bit after the colon at 
the end): I've seen cases where this part of an error message hasn't been 
checked properly and the string is actually invalid for some reason. (We don't 
need to test every possible lower-level code path that could result in the 
specific failure, just one example).

You may also wish to show that the binary is not dumped (as opposed to garbage 
being dumped).

https://github.com/llvm/llvm-project/pull/185425
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to