jtstogel wrote:

> Can we get a unit test somewhere that exercises this overload with a comment 
> that it's used downstream so that this doesn't get deleted later by virtue of 
> being unused in tree?

Good idea, done. Also, moved around some helpers in 
`clang/unittests/Basic/DiagnosticTest.cpp` and updated `WithMessage` to accept 
a matcher.

https://github.com/llvm/llvm-project/pull/190374
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to