================
@@ -28,16 +28,24 @@ namespace clang {
 /// each \a ModuleManager sees the same files.
 class InMemoryModuleCache : public llvm::RefCountedBase<InMemoryModuleCache> {
   struct PCM {
----------------
cyndyishida wrote:

Can Size/ModTime ever stay null for the lifetime of `PCM` saved in 
`InMemoryModuleCache`? My assumption is no, because this documentation states 
this is only used for implicit module builds, but the logic in 
`ModuleManager::addModule` can trigger when resolving explicit modules which do 
not rely on `ModTime`, so I am unsure.

https://github.com/llvm/llvm-project/pull/190207
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to