Xazax-hun wrote:

Oh interesting. There is an API called `hasNoReturnElement` on the CfgBlock, so 
we could alternatively use that one.

That being said, it does not solve the `throw` case. It would definitely be 
great if the CFG was more faithful for exceptions but I am not sure how big of 
a project would it be to fix this aspect of our CFG. So I am fine with the 
original approach and maybe we can add a comment to rely more on the shape of 
the CFG once this is fixed.

If you feel adventurous, you could give the CFG changes a try in a separate PR. 

https://github.com/llvm/llvm-project/pull/190345
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to