================
@@ -303,7 +304,19 @@ class AggExprEmitter : public StmtVisitor<AggExprEmitter> {
                      "AggExprEmitter: VisitSubstNonTypeTemplateParmExpr");
   }
   void VisitConstantExpr(ConstantExpr *e) {
-    cgf.cgm.errorNYI(e->getSourceRange(), "AggExprEmitter: VisitConstantExpr");
+    ensureDest(cgf.getLoc(e->getSourceRange()), e->getType());
+
+    if (mlir::Attribute result = ConstantEmitter(cgf).tryEmitConstantExpr(e)) {
----------------
erichkeane wrote:

Yeah, I found that too.  I picked up my test partially from there.  

I didn't have claude claim that (I actually sycc'ed it on it too), but didn't 
come up with anything.  The original line was added without a test that hits 
it, so I doubt we'll hit it.

We DID implement it near-token identical, so I suspect the implementation is ok 
though.

https://github.com/llvm/llvm-project/pull/190631
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to