https://github.com/inbelic approved this pull request.
Mostly LGTM, I might prefer a work-list algorithm but I won't block on it. For other reviewers, the applicable testing is in `AggregateSplatConstantExpr.hlsl` and `ElementwiseCastConstantExpr.hlsl`. Side-note: I think breaking this pr into 3 commits consisting of: - aggregate splat code change + adding the flag to corresponding test - elementwise cast code chang + adding the flag to corresponding test - adding the flag to all other static_assert tests would have made reviewing easier. To be clear, not 3 seperate prs but for this pr to have 3 commits. https://github.com/llvm/llvm-project/pull/189126 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
