ioeric added a comment. This is very nice! Thanks!
Looks good to me; I'll let Manuel stamp the patch for you. ================ Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:56 + virtual Expected<AtomicChanges> + createSourceReplacements(RefactoringRuleContext &Context) = 0; + ---------------- Can this be `private`? ================ Comment at: include/clang/Tooling/Refactoring/RefactoringActionRules.h:77 + virtual Expected<SymbolOccurrences> + findSymbolOccurrences(RefactoringRuleContext &Context) = 0; ---------------- `private`? Repository: rL LLVM https://reviews.llvm.org/D37681 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
