andrew.w.kaylor added inline comments.
================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6031 InGroup<PointerArith>; +def ext_gnu_null_ptr_arith : Extension< + "arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension">, ---------------- efriedma wrote: > andrew.w.kaylor wrote: > > efriedma wrote: > > > "extension" isn't really right here; this shouldn't be an error in > > > -pedantic-errors mode. Probably best to just stick this into the > > > NullPointerArithmetic, like the other new warning. > > So how should a word the warning? Just this: > > > > "arithmetic on a null pointer treated as a cast from integer to pointer"? > That wasn't what I meant; the current wording is fine. I meant this should be > something like `def warn_gnu_null_ptr_arith : Warning<`. OK. I think I understand the behavior you wanted. I just thought maybe the current wording might be technically incorrect. I wasn't sure how precisely defined we consider "extension" to be in this context. https://reviews.llvm.org/D37042 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
