mgorny wrote:
This change broke tests on 32-bit platforms, where `memset()` doesn't take a
`i64`:
```
FAIL: Clang :: CodeGen/2004-02-13-Memset.c (3670 of 24534)
******************** TEST 'Clang :: CodeGen/2004-02-13-Memset.c' FAILED
********************
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 1
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang
-cc1 -internal-isystem
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/23/include
-nostdsysteminc
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c
-emit-llvm -o - | /usr/lib/llvm/23/bin/FileCheck
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c
# executed command:
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang
-cc1 -internal-isystem
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/23/include
-nostdsysteminc
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c
-emit-llvm -o -
# executed command: /usr/lib/llvm/23/bin/FileCheck
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c
# .---command stderr------------
# |
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c:8:12:
error: CHECK: expected string not found in input
# | // CHECK: call void @llvm.memset{{.*}}i8 4, i64 1000
# | ^
# | <stdin>:1:1: note: scanning from here
# | ; ModuleID =
'/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c'
# | ^
# | <stdin>:14:2: note: possible intended match here
# | call void @llvm.memset.p0.i32(ptr align 4 %0, i8 4, i32 1000, i1 false)
# | ^
# |
# | Input file: <stdin>
# | Check file:
/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c
# |
# | -dump-input=help explains the following input dump.
# |
# | Input was:
# | <<<<<<
# | 1: ; ModuleID =
'/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c'
# | check:8'0
X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: no match found
# | 2: source_filename =
"/var/tmp/portage/llvm-core/clang-23.0.0.9999/work/clang/test/CodeGen/2004-02-13-Memset.c"
# | check:8'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 3: target datalayout =
"e-m:e-p:32:32-p270:32:32-p271:32:32-p272:64:64-i128:128-f64:32:64-f80:32-n8:16:32-S128"
# | check:8'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 4: target triple = "i686-pc-linux-gnu"
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 5:
# | check:8'0 ~
# | 6: ; Function Attrs: noinline nounwind optnone
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | .
# | .
# | .
# | 9: %X.addr = alloca ptr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 10: %Y.addr = alloca ptr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 11: store ptr %X, ptr %X.addr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 12: store ptr %Y, ptr %Y.addr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 13: %0 = load ptr, ptr %X.addr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 14: call void @llvm.memset.p0.i32(ptr align 4 %0, i8 4, i32
1000, i1 false)
# | check:8'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | check:8'1 ?
possible intended match
# | 15: %1 = load ptr, ptr %Y.addr, align 4
# | check:8'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 16: call void @llvm.memset.p0.i32(ptr align 1 %1, i8 0, i32 100,
i1 false)
# | check:8'0
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# | 17: ret void
# | check:8'0 ~~~~~~~~~~
# | 18: }
# | check:8'0 ~~
# | 19:
# | check:8'0 ~
# | .
# | .
# | .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1
--
********************
```
https://github.com/llvm/llvm-project/pull/191092
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits