aengelke wrote:

CI failures are #182526 again. Clang tooling now "matches" 
`llvm-build/tools/clang/tools/extra/test/clang-tidy/infrastructure/Output/custom-query-check.cpp.tmp/cqc-main.cpp`
 with 
`llvm-build/tools/clang/tools/extra/clangd/unittests/DecisionForestRuntimeTest.cpp`,
 which is generated into the build directory.

I tried to remove the solely prefix-based matching of files (for score=0), but 
then a series of other tests fail with `Compile command not found.`. So this 
has been broken and unintentionally picked up LLVM build flags since at least 
years. To get builds back to green, I propose to disable the test (#191635).

According to Maintainers.md, Clang tooling appears to have no dedicated 
maintainer/be unmaintained. If no one cares and actively maintains this part of 
Clang, we should do something about this, even if it means removing it. It 
can't be that this repeatedly breaks our builds due to *entirely unrelated 
changes*.

Tagging @sam-mccall, who according to git log wrote the matching logic in 
ea9773ac69389c6, and @AaronBallman as Clang lead maintainer.

https://github.com/llvm/llvm-project/pull/191402
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to