vlad.tsyrklevich marked an inline comment as done. vlad.tsyrklevich added inline comments.
================ Comment at: docs/SanitizerSpecialCaseList.rst:57 + +Sections are regular expressions written in square brackets that denote which +sanitizer the following entries apply to. For example, ``[address]`` specifies ---------------- eugenis wrote: > Section names are regular expressions > > also, not really a regular expression, more like a wildcard; I don't know > what's the right term for this They are not just wildcards in the sense that `cfi-vcall|cfi-icall` is more than just wildcard matching. I could add a line that explains how `*` behaves here as well? (similarly to what we have in the entries paragraph) ================ Comment at: lib/CodeGen/CGDeclCXX.cpp:322 + if (getLangOpts().Sanitize.hasOneOf(ASanMask)) + if (!isInSanitizerBlacklist(ASanMask, Fn, Loc)) Fn->addFnAttr(llvm::Attribute::SanitizeAddress); ---------------- eugenis wrote: > vlad.tsyrklevich wrote: > > This use of ASanMask could also confound address & kernel-address as > > @eugenis pointed out. > It would be more readable to split it in two if-s, IMHO: one for asan, one > for kernel-asan. > Agreed. https://reviews.llvm.org/D37925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits