rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lib/Sema/SemaDeclCXX.cpp:2871
+      InvalidDecl =
+          (DS.getStorageClassSpec() == DeclSpec::SCS_typedef || MSPropertyAttr)
+              ? 0
----------------
erichkeane wrote:
> Note: Clang format did this craziness... I'm open to whatever format you guys 
> would prefer.
Maybe this would be better expressed in an if /else if chain like:
  if (!isFunc && (DS.getStorageClassSpec() == SCS_typedef || MSPropertyAttr))
    InvalidDecl = 0;
  else if (!isFunc)
    InvalidDecl = 1;
...


https://reviews.llvm.org/D38092



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to