Author: kongyi Date: Mon Sep 25 10:36:54 2017 New Revision: 314124 URL: http://llvm.org/viewvc/llvm-project?rev=314124&view=rev Log: [Sema] Null check in BuildDeclarationNameExpr
Qualtype may point to null if we cannot infer its type yet. Fixes PR33843 Differential Revision: https://reviews.llvm.org/D38158 Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/test/SemaCXX/typo-correction-crash.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=314124&r1=314123&r2=314124&view=diff ============================================================================== --- cfe/trunk/lib/Sema/SemaExpr.cpp (original) +++ cfe/trunk/lib/Sema/SemaExpr.cpp Mon Sep 25 10:36:54 2017 @@ -2803,6 +2803,8 @@ ExprResult Sema::BuildDeclarationNameExp { QualType type = VD->getType(); + if (type.isNull()) + return ExprError(); if (auto *FPT = type->getAs<FunctionProtoType>()) { // C++ [except.spec]p17: // An exception-specification is considered to be needed when: Modified: cfe/trunk/test/SemaCXX/typo-correction-crash.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/typo-correction-crash.cpp?rev=314124&r1=314123&r2=314124&view=diff ============================================================================== --- cfe/trunk/test/SemaCXX/typo-correction-crash.cpp (original) +++ cfe/trunk/test/SemaCXX/typo-correction-crash.cpp Mon Sep 25 10:36:54 2017 @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++17 -verify %s auto check1() { return 1; return s; // expected-error {{use of undeclared identifier 's'}} @@ -19,3 +19,5 @@ struct FooRecord { }; FooRecord::NestedNamespace::type x; // expected-error {{no member named 'NestedNamespace' in 'FooRecord'; did you mean 'BarNamespace::NestedNamespace'?}} void cast_expr(int g) { +int(n)(g); } // expected-error {{undeclared identifier 'n'}} + +void bind() { for (const auto& [test,_] : _test_) { }; } // expected-error {{undeclared identifier '_test_'}} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
