adams381 wrote: Closing this in favor of a series of smaller, focused PRs per @andykaylor's review feedback to break it down into smaller pieces.
The split: - #195725 — `[mlir][ABI]` Test target + classification injection helper. Dialect-agnostic foundation that lets the rest of the series write `cir-opt`-driven `.cir` tests against the rewriter without depending on the in-progress LLVM ABI library targets. - #195737 — `[CIR]` `CallConvLowering` pass + Direct/Ignore ABI rewriting. The actual MLIR pass and `CIRABIRewriteContext` skeleton. - #195745 — `[CIR]` Extend (signext/zeroext) handling. - #195879 — `[CIR]` Direct coerce-in-registers + new `cir.reinterpret_cast` op + your five inline review comments addressed. Subsequent PRs in the series cover Indirect/sret, Indirect/byval, and Expand/flatten, replacing #192124. The C++ unit tests from this PR are ported to `cir-opt`-driven `.cir` tests across the new series (audit table in #195737's description). https://github.com/llvm/llvm-project/pull/192119 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
