https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/196119
>From 1058825c59497331a8e5ca7545abad7687a20355 Mon Sep 17 00:00:00 2001 From: Matt Arsenault <[email protected]> Date: Wed, 6 May 2026 18:03:34 +0100 Subject: [PATCH] clang: Remove unnecessary convertion from StringRef to std::string --- clang/lib/Driver/ToolChains/AMDGPU.cpp | 2 +- clang/lib/Driver/ToolChains/AMDGPU.h | 2 +- clang/lib/Driver/ToolChains/HIPAMD.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/clang/lib/Driver/ToolChains/AMDGPU.cpp b/clang/lib/Driver/ToolChains/AMDGPU.cpp index 4eda95e3b111b..3a1e82ec01b74 100644 --- a/clang/lib/Driver/ToolChains/AMDGPU.cpp +++ b/clang/lib/Driver/ToolChains/AMDGPU.cpp @@ -1073,7 +1073,7 @@ RocmInstallationDetector::getCommonBitcodeLibs( llvm::SmallVector<ToolChain::BitCodeLibraryInfo, 12> ROCMToolChain::getCommonDeviceLibNames( - const llvm::opt::ArgList &DriverArgs, const std::string &GPUArch, + const llvm::opt::ArgList &DriverArgs, llvm::StringRef GPUArch, Action::OffloadKind DeviceOffloadingKind) const { auto Kind = llvm::AMDGPU::parseArchAMDGCN(GPUArch); const StringRef CanonArch = llvm::AMDGPU::getArchNameAMDGCN(Kind); diff --git a/clang/lib/Driver/ToolChains/AMDGPU.h b/clang/lib/Driver/ToolChains/AMDGPU.h index 93eb441385949..20b9365c91bbf 100644 --- a/clang/lib/Driver/ToolChains/AMDGPU.h +++ b/clang/lib/Driver/ToolChains/AMDGPU.h @@ -148,7 +148,7 @@ class LLVM_LIBRARY_VISIBILITY ROCMToolChain : public AMDGPUToolChain { // Returns a list of device library names shared by different languages llvm::SmallVector<BitCodeLibraryInfo, 12> getCommonDeviceLibNames(const llvm::opt::ArgList &DriverArgs, - const std::string &GPUArch, + llvm::StringRef GPUArch, Action::OffloadKind DeviceOffloadingKind) const; SanitizerMask getSupportedSanitizers() const override { diff --git a/clang/lib/Driver/ToolChains/HIPAMD.cpp b/clang/lib/Driver/ToolChains/HIPAMD.cpp index b4ff90c1d61f0..b5271e7593dc6 100644 --- a/clang/lib/Driver/ToolChains/HIPAMD.cpp +++ b/clang/lib/Driver/ToolChains/HIPAMD.cpp @@ -420,8 +420,8 @@ HIPAMDToolChain::getDeviceLibs(const llvm::opt::ArgList &DriverArgs, assert(!GpuArch.empty() && "Must have an explicit GPU arch."); // Add common device libraries like ocml etc. - for (auto N : getCommonDeviceLibNames(DriverArgs, GpuArch.str(), - DeviceOffloadingKind)) + for (auto N : + getCommonDeviceLibNames(DriverArgs, GpuArch, DeviceOffloadingKind)) BCLibs.emplace_back(N); // Add instrument lib. _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
