https://github.com/rjodinchr commented:

`clspv` relies on 2 libraries, `clspv-unknown-unknown` & 
`clspv64-unknown-unknown` before that patch.

I've updated clspv to use `spirv-unknown-vulkan` & `spirv64-unknown-vulkan` to 
use this patch.

`spirv64-unknown-vulkan/libclc.bc` is generated without issue, but the build 
fails with `spirv-unknown-vulkan`:

```
FAILED: [code=1] 
libclc/CMakeFiles/clc_builtins_spirv_unknown_vulkan.dir/clc/lib/generic/math/clc_native_exp.cl.o
/home/rjodin/git/clvk/build/external/clspv/third_party/llvm/bin/clang -x cl 
-D_DEBUG -D_GLIBCXX_ASSERTIONS -D__CLC_GENERIC_ADDRSPACE_VAL=0 
-D__CLC_PRIVATE_ADDRSPACE_VAL=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS 
-D__STDC_LIMIT_MACROS 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/include 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/async
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/atomic
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/collective
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/common
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/conversion
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/geometric
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/integer
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/math
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/mem_fence
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/misc
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/relational
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/shared
 -I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/subgroup
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/workitem
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/vulkan/integer
 
-I/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/vulkan/math
 -flto --target=spirv-unknown-vulkan -nostdlib -nostdlibinc -cl-no-stdinc 
-cl-std=CL3.0 -include opencl-c-base.h -Werror=undef -Wall -Wextra 
-fdiscard-value-names -ffp-contract=fast-honor-pragmas 
-fdenormal-fp-math=dynamic -Wno-unknown-assumption -U__opencl_c_int64 
-fapprox-func -MD -MT 
libclc/CMakeFiles/clc_builtins_spirv_unknown_vulkan.dir/clc/lib/generic/math/clc_native_exp.cl.o
 -MF 
libclc/CMakeFiles/clc_builtins_spirv_unknown_vulkan.dir/clc/lib/generic/math/clc_native_exp.cl.o.d
 -c -o 
libclc/CMakeFiles/clc_builtins_spirv_unknown_vulkan.dir/clc/lib/generic/math/clc_native_exp.cl.o
 
/home/rjodin/git/clvk/external/clspv/third_party/llvm/libclc/clc/lib/generic/math/clc_native_exp.cl
clang (LLVM option parsing): Unknown command line argument '-spirv-ext=all'.  
Try: 'clang (LLVM option parsing) --help'
clang (LLVM option parsing): Did you mean '--slp-revec=all'?
ninja: build stopped: subcommand failed.
```
It feels like LLVM uses `spirv32` not `spirv`, it might not be the issue, but 
it is unclear to me where the error is coming from right now.

https://github.com/llvm/llvm-project/pull/196351
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to