tarunprabhu wrote: > > Are you saying that with this change, `-Werror` will upgrade warnings to > > errors for everything _except_ warnings issued by the driver? > > Yes > > Edit: To elaborate, this is the current behavior, so this PR does not change > that. The reason why this came up was that the function that the PR uses to > handle the -Wno-xyz flags in the driver also interprets -Werror. Now, with > -Werror, driver warnings would become errors. Since the driver code wouldn't > proceed to compilation if there were errors, the OpenMP warning about > incomplete implementation (that we issue in most cases, and that is emitted > from the driver) would prevent compilation, which is definitely not the > desired behavior.
Thanks for the clarification; it was very helpful. A couple of questions: 1. Do you know if there is anything in clang that behaves the same way? 2. If not, do you think this behavior is worth changing in flang? I would expect `-Werror` to error out on all warnings, rather than just a subset of them. The option is generally used in cases where "clean" builds are valued. It seems strange to me to have both `-Werror` and a standard for which support is acknowledged to be incomplete. It would be good, IMO, if clang and flang were consistent to the extent possible. So, if there is no precedence for this in clang, I would advocate for changing this behavior - even if it would cause issues for some users. https://github.com/llvm/llvm-project/pull/196354 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
