Author: Sean Perry Date: 2026-05-08T11:34:21-04:00 New Revision: 0f23bffeae55ae29ee681e5aeedf4300f5700eb4
URL: https://github.com/llvm/llvm-project/commit/0f23bffeae55ae29ee681e5aeedf4300f5700eb4 DIFF: https://github.com/llvm/llvm-project/commit/0f23bffeae55ae29ee681e5aeedf4300f5700eb4.diff LOG: Symbol names on arm64 can have an extra char on front of name (#194937) My previous change (https://github.com/llvm/llvm-project/pull/192132) didn't work with aarch64. The symbol name has the \x01 on the front and the greps fail. Update the expression for the grep to allow for that char. Sorry about that. The original grep with `@pipe` also fails on aarch64 & macos. The negative test those greps are doing will always pass on aarch64 & macos. That should be looking for the updated symbol name too. Added: Modified: clang/test/CodeGen/2008-07-31-asm-labels.c Removed: ################################################################################ diff --git a/clang/test/CodeGen/2008-07-31-asm-labels.c b/clang/test/CodeGen/2008-07-31-asm-labels.c index 71be9378233d4..f0ca5da8875da 100644 --- a/clang/test/CodeGen/2008-07-31-asm-labels.c +++ b/clang/test/CodeGen/2008-07-31-asm-labels.c @@ -1,26 +1,25 @@ -// RUN: %clang_cc1 -emit-llvm -o %t %s -// RUN: not grep "@pipe()" %t -// RUN: grep '_thisIsNotAPipe' %t | count 3 -// RUN: not grep '@g0' %t -// RUN: grep '_renamed' %t | count 2 -// RUN: %clang_cc1 -DUSE_DEF -emit-llvm -o %t %s -// RUN: not grep "@pipe()" %t -// RUN: grep '_thisIsNotAPipe' %t | count 3 +// RUN: %clang_cc1 -emit-llvm -o - %s |FileCheck %s -check-prefixes CHECK,CHECKREF +// RUN: %clang_cc1 -DUSE_DEF -emit-llvm -o - %s |FileCheck %s -check-prefixes CHECK,CHECKDEF // <rdr://6116729> +//CHECK: _renamed{{.*}} = external {{.*}}global void pipe() asm("_thisIsNotAPipe"); void f0(void) { pipe(); +//CHECK: call {{.*}}_thisIsNotAPipe } void pipe(int); +//CHECKREF: declare {{.*}}_thisIsNotAPipe void f1(void) { pipe(1); +//CHECK: call {{.*}}_thisIsNotAPipe } #ifdef USE_DEF +//CHECKDEF: define {{.*}}_thisIsNotAPipe void pipe(int arg) { int x = 10; } @@ -30,4 +29,5 @@ void pipe(int arg) { extern int g0 asm("_renamed"); int f2(void) { return g0; +//CHECK: load {{.*}}_renamed } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
