================
@@ -3289,27 +3294,49 @@ void PragmaCommentHandler::HandlePragma(Preprocessor
&PP,
return;
}
- // Verify that this is one of the 5 explicitly listed options.
+ // Verify that this is one of the 6 explicitly listed options.
IdentifierInfo *II = Tok.getIdentifierInfo();
PragmaMSCommentKind Kind =
- llvm::StringSwitch<PragmaMSCommentKind>(II->getName())
- .Case("linker", PCK_Linker)
- .Case("lib", PCK_Lib)
- .Case("compiler", PCK_Compiler)
- .Case("exestr", PCK_ExeStr)
- .Case("user", PCK_User)
- .Default(PCK_Unknown);
+ llvm::StringSwitch<PragmaMSCommentKind>(II->getName())
+ .Case("linker", PCK_Linker)
+ .Case("lib", PCK_Lib)
+ .Case("compiler", PCK_Compiler)
+ .Case("exestr", PCK_ExeStr)
+ .Case("user", PCK_User)
+ .Case("copyright", PCK_Copyright)
+ .Default(PCK_Unknown);
+
if (Kind == PCK_Unknown) {
PP.Diag(Tok.getLocation(), diag::err_pragma_comment_unknown_kind);
return;
}
+ // Handle AIX Target restrictions (i.e., warn on all non-copyright kinds).
+ if (PP.getTargetInfo().getTriple().isOSAIX() && Kind != PCK_Copyright) {
+ // pragma comment kinds linker, lib, compiler, exestr and user are
+ // ignored when targeting AIX.
----------------
hubert-reinterpretcast wrote:
Let's avoid the long list of specific pragma comment kinds.
```suggestion
// Currently, pragma comment kinds aside from "copyright" are not fully
// implemented by Clang for AIX targets.
```
https://github.com/llvm/llvm-project/pull/178184
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
