timon-ul wrote: > Happy to do it in this PR if you'd like, or split it into a follow-up to keep > this one focused on InsertReplaceEdit and not changing the existing logic.
You got me convinced. Let's do it in a follow up PR. I was hesistant, because I would prefer to keep the codebase clean, but I agree that if you already touch the other function it makes more sense to combine it with fixing the lacking behaviour and at that point it makes sense for it to be its own PR. > `findTokenAfterCompletionPoint` assumes we're at the end of a token and is > looking for the next token (ignoring whitespace) Just wanted to note that I don't think ignoring the whitespace is desired behaviour, at least I cannot see any reason as to when it would be. Anyway I would be ready to merge this once you resolve the pending merge conflicts with master. https://github.com/llvm/llvm-project/pull/187623 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
