=?utf-8?q?Donát?= Nagy <[email protected]>, =?utf-8?q?Donát?= Nagy <[email protected]>, =?utf-8?q?Donát?= Nagy <[email protected]>, =?utf-8?q?Donát?= Nagy <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
https://github.com/isuckatcs approved this pull request. > As I describe in the commit message, there is no PreStmt<ArrayInitLoop> > checker (neither upstream nor under private development AFAIK), so the buggy > logic doesn't cause observable buggy behavior – but it is still buggy and we > should still fix it. I was only asking to see if there is any way to test the change, or write some test cases that can be used to check some other change breaks this case. > I feel that a single-word change is too small to be a standalone commit A commit should encapsulate changes that belong together regardless of their size. The commit contains a bugfix. The fact that the fix is only 1 word is irrelevant, it is what needs to be done to fix the issue. Removing the node builder is another change, which doesn't affect functionality, hence it should be a separate commit. I'm not sure if GH allows it, but both can be merged in the same PR, just don't squash them. https://github.com/llvm/llvm-project/pull/196974 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
