================
@@ -30,6 +32,13 @@ mlir::Block *replaceCallWithTryCall(cir::CallOp callOp, 
mlir::Block *unwindDest,
                                     mlir::Location loc,
                                     mlir::RewriterBase &rewriter);
 
+/// Collect ops in blocks that are unreachable from their region's entry,
+/// appending them to \p ops. Used by CIR passes that drive
+/// `applyPartialConversion` and need to feed it operations the conversion
+/// driver's dominance-order traversal would otherwise skip.
+void collectUnreachable(mlir::Operation *parent,
----------------
erichkeane wrote:

Can we change this to returning the vector instead of taking it by reference? 
It doesn't seem required to have these created by the caller, right? 

https://github.com/llvm/llvm-project/pull/197334
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to