argothiel wrote: Hi, @timon-ul,
Thank you for the review. These are all valid issues, however I think they go a bit outside of this PR's scope. Ad. 1. Smileys issue has been introduced by #187623. This change doesn't introduce any tests with smileys, it doesn't even touch any such tests. This PR is focused on fixing parens suppression in mid-identifier code-completion and this is independent from the encoding. Ad. 2. This is a separate issue, unrelated to the mid-identifiers issue. It's broken in general, also in the insert mode, and it's even independent from the `()` parens. Even things like `std::ve^<int>` trigger it, not suppressing correctly the triangular brackets. Ad. 3. Unfortunately, I also don't have intuition for the `insert` mode. For me, it's like _legacy broken mode_, and all we care about is to keep it more-or-less backwards compatible. I think many LSP servers were trying to implement some of the replace logic in the insert mode, before the replace logic was officially added to LSP 3.16.0 in 2020. But I think it's too late to change it now, given that users got used to its behavior, unless until we get some real bug reports or requests. https://github.com/llvm/llvm-project/pull/197249 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
