https://github.com/NagyDonat approved this pull request.

Looks good to me.

I added two very minor suggestions in the tests, but they are completely 
optional, feel free to keep the `if` if you prefer.

Also consider using `Fixes #....` instead of `Issue : #...` in the PR 
description, because it is recognized by github and ensures that the issue is 
closed when this PR is merged. (Of course, if you want to avoid that, feel free 
to keep the current phrasing.)



https://github.com/llvm/llvm-project/pull/197489
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to