Author: Jan Svoboda Date: 2026-05-13T18:50:49Z New Revision: f814cf5a058feab412640ca415e570bbbdb2ee82
URL: https://github.com/llvm/llvm-project/commit/f814cf5a058feab412640ca415e570bbbdb2ee82 DIFF: https://github.com/llvm/llvm-project/commit/f814cf5a058feab412640ca415e570bbbdb2ee82.diff LOG: [clang][deps] Remove unnecessary function overload (#197528) NFC Added: Modified: clang/include/clang/DependencyScanning/DependencyScanningWorker.h clang/lib/DependencyScanning/DependencyScanningWorker.cpp clang/lib/Driver/ModulesDriver.cpp Removed: ################################################################################ diff --git a/clang/include/clang/DependencyScanning/DependencyScanningWorker.h b/clang/include/clang/DependencyScanning/DependencyScanningWorker.h index 88ed0f0188913..b722f5a7f9d9b 100644 --- a/clang/include/clang/DependencyScanning/DependencyScanningWorker.h +++ b/clang/include/clang/DependencyScanning/DependencyScanningWorker.h @@ -141,23 +141,6 @@ class DependencyScanningWorker { ~DependencyScanningWorker(); - /// Run the dependency scanning worker for the given frontend command-line, - /// and report the discovered dependencies to the provided consumer. - /// - /// OverlayFS should be based on the Worker's dependency scanning file-system - /// and can be used to provide any input specified on the command-line as - /// in-memory file. If no overlay file-system is provided, the Worker's - /// dependency scanning file-system is used instead. - /// - /// \returns false if any errors occurred (with diagnostics reported to - /// \c DiagConsumer), true otherwise. - bool computeDependencies( - StringRef WorkingDirectory, ArrayRef<std::string> CommandLine, - DependencyConsumer &DepConsumer, DependencyActionController &Controller, - DiagnosticConsumer &DiagConsumer, - llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS = - nullptr); - /// Run the dependency scanning tool for all given frontend command-lines, /// and report the discovered dependencies to the provided consumer. /// @@ -172,8 +155,7 @@ class DependencyScanningWorker { StringRef WorkingDirectory, ArrayRef<ArrayRef<std::string>> CommandLines, DependencyConsumer &DepConsumer, DependencyActionController &Controller, DiagnosticConsumer &DiagConsumer, - llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS = - nullptr); + IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS = nullptr); llvm::vfs::FileSystem &getVFS() const { return *DepFS; } diff --git a/clang/lib/DependencyScanning/DependencyScanningWorker.cpp b/clang/lib/DependencyScanning/DependencyScanningWorker.cpp index 90d2725a6b47a..ef4d57c42b4ff 100644 --- a/clang/lib/DependencyScanning/DependencyScanningWorker.cpp +++ b/clang/lib/DependencyScanning/DependencyScanningWorker.cpp @@ -54,16 +54,6 @@ static bool createAndRunToolInvocation( Diags.getClient()); } -bool DependencyScanningWorker::computeDependencies( - StringRef WorkingDirectory, ArrayRef<std::string> CommandLine, - DependencyConsumer &DepConsumer, DependencyActionController &Controller, - DiagnosticConsumer &DiagConsumer, - llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS) { - return computeDependencies(WorkingDirectory, - ArrayRef<ArrayRef<std::string>>(CommandLine), - DepConsumer, Controller, DiagConsumer, OverlayFS); -} - bool DependencyScanningWorker::computeDependencies( StringRef WorkingDirectory, ArrayRef<ArrayRef<std::string>> CommandLines, DependencyConsumer &DepConsumer, DependencyActionController &Controller, diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp index f439c7e733954..3f7a9f346accd 100644 --- a/clang/lib/Driver/ModulesDriver.cpp +++ b/clang/lib/Driver/ModulesDriver.cpp @@ -568,7 +568,7 @@ scanDependenciesForJob(const Command &Job, ScanningWorkerPool &WorkerPool, deps::FullDependencyConsumer DepConsumer(WorkerBundleHandle->SeenModules); if (WorkerBundleHandle->Worker->computeDependencies( - WorkingDirectory, CC1CommandLine, DepConsumer, LookupController, + WorkingDirectory, {CC1CommandLine}, DepConsumer, LookupController, DiagConsumer)) MaybeTUDeps = DepConsumer.takeTranslationUnitDeps(); } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
