erichkeane wrote: > @erichkeane This was my mistake. I treated silence as approval and landed > this too quickly and I didn't account for the weekend. I can revert the PR if > you think that's best. > > Do you have any thoughts on the renaming?
We don't take silence as approval, we need positive approval from folks. As far as the rename: I don't think I feel strongly here, but perhaps our maintainers of this (@efriedma-quic ?) might have an idea. As the questions/concerns are minor so far, I think I'm OK with us holding off on reverting unless someone spots one that needs it. I WOULD like @shafik to make sure he's happy though, since he had a number of questions that I tried to answer but we should make sure he was satisfied by them. https://github.com/llvm/llvm-project/pull/196240 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
