ckandeler wrote:

> Edit: that being said I wonder if there even is any other code action that 
> queuries the index, given how long this issue has been open I would expect 
> not, but again I would need to check. Reason I am wondering about this is 
> that creating infrastructure for something that does not exist might not be 
> neccessary. Yes this does not scale but what if there never is a need for it 
> to scale (I doubt it, but we could just cross that bridge once we get there). 
> So maybe it is fine to delay the decision to the 2nd code action that will 
> need an Index lookup. 

That was my reasoning in the discussion as well.

> That being said it would probably make sense to leave a comment about this 
> where the lookup happens currently.

Done.

https://github.com/llvm/llvm-project/pull/71950
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to