kbelochapka wrote:
>
> However, the PR seems to be in an odd state? I don't see these files and a
> ton of reviewers got added, and I also see some fixes that seem to have been
> undone (e.g. the change to CleanUp in LTO::run is back).
>
> Also, if you can avoid force pushing that would make reviewing significantly
> easier - with force pushing I can't compare to prior versions of the PR in
> github, so I have to restart the review from scratch after every force push
> which for a PR this large makes the review take even longer.
@teresajohnson ,
It looks like there were some GitHub issues yesterday—you already noticed that
extra reviewers were added and some tests failed unexpectedly. I assumed the
failures were due to a merge conflict, so I rebased the branch with the main
branch and force-pushed the updated commit. Going forward, I will avoid to do
force pushing.
` llvm::scope_exit CleanUp([this]() { LTO::cleanup(); });` is there, on line
`1302`, changed from `cleanup()` to `LTO::cleanup()` since it is virtual
method.
https://github.com/llvm/llvm-project/pull/192629
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
