github-actions[bot] wrote:
<!--LLVM CODE LINT COMMENT: clang-tidy-->
:warning: C/C++ code linter, clang-tidy found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
```bash
git diff -U0 origin/main...HEAD --
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.h
clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py -path build -p1
-quiet
```
</details>
<details>
<summary>
View the output from clang-tidy here.
</summary>
```
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:53:13:
warning: invalid case style for function 'BodyIsArrayDeleteOfParam'
[readability-identifier-naming]
53 | static bool BodyIsArrayDeleteOfParam(const Stmt *Body,
| ^~~~~~~~~~~~~~~~~~~~~~~~
| bodyIsArrayDeleteOfParam
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:79:23:
warning: invalid case style for function 'FindParentVarDecl'
[readability-identifier-naming]
79 | static const VarDecl *FindParentVarDecl(ASTContext &Ctx, const Stmt *S)
{
| ^~~~~~~~~~~~~~~~~
| findParentVarDecl
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:112:18:
warning: invalid case style for function 'ExtractWrittenElementType'
[readability-identifier-naming]
112 | static StringRef ExtractWrittenElementType(const TypeSourceInfo *TSI,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| extractWrittenElementType
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:117:3:
warning: variable 'TL' of type 'TypeLoc' can be declared 'const'
[misc-const-correctness]
117 | TypeLoc TL = TSI->getTypeLoc().getUnqualifiedLoc();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:124:3:
warning: variable 'ArgTL' of type 'TypeLoc' can be declared 'const'
[misc-const-correctness]
124 | TypeLoc ArgTL = ArgTSI->getTypeLoc();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:125:3:
warning: variable 'R' of type 'CharSourceRange' can be declared 'const'
[misc-const-correctness]
125 | CharSourceRange R =
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:144:17:
warning: invalid case style for function 'GetDeleterParamPointee'
[readability-identifier-naming]
144 | static QualType GetDeleterParamPointee(const Expr *DeleterArg) {
| ^~~~~~~~~~~~~~~~~~~~~~
| getDeleterParamPointee
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:151:5:
warning: variable 'P' of type 'QualType' can be declared 'const'
[misc-const-correctness]
151 | QualType P = CallOp->getParamDecl(0)->getType();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:161:7:
warning: variable 'P' of type 'QualType' can be declared 'const'
[misc-const-correctness]
161 | QualType P = FD->getParamDecl(0)->getType();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:177:5:
warning: variable 'T' of type 'QualType' can be declared 'const'
[misc-const-correctness]
177 | QualType T = Arg.getAsType();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:189:13:
warning: invalid case style for function 'ResolveRAngleLocs'
[readability-identifier-naming]
189 | static void ResolveRAngleLocs(const CXXConstructExpr *Ctor,
| ^~~~~~~~~~~~~~~~~
| resolveRAngleLocs
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:208:5:
warning: variable 'TL' of type 'TypeLoc' can be declared 'const'
[misc-const-correctness]
208 | TypeLoc TL = ParentVD->getTypeSourceInfo()->getTypeLoc();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:228:9:
warning: variable 'CtorLoc' of type 'SourceLocation' can be declared 'const'
[misc-const-correctness]
228 | SourceLocation CtorLoc = Ctor->getBeginLoc();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:229:9:
warning: variable 'LParenLoc' of type 'SourceLocation' can be declared 'const'
[misc-const-correctness]
229 | SourceLocation LParenLoc =
Ctor->getParenOrBraceRange().getBegin();
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:253:13:
warning: variable 'Next' of type 'SourceLocation' can be declared 'const'
[misc-const-correctness]
253 | SourceLocation Next =
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:289:13:
warning: invalid case style for function 'IsInsideAssignment'
[readability-identifier-naming]
289 | static bool IsInsideAssignment(ASTContext &Ctx, const CXXConstructExpr
*Ctor) {
| ^~~~~~~~~~~~~~~~~~
| isInsideAssignment
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:321:18:
warning: invalid case style for function 'MakeArrayInsertionFix'
[readability-identifier-naming]
321 | static FixItHint MakeArrayInsertionFix(SourceLocation Loc,
SourceManager &SM,
| ^~~~~~~~~~~~~~~~~~~~~
| makeArrayInsertionFix
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:333:1:
warning: invalid case style for function 'BuildRemoveDeleterFix'
[readability-identifier-naming]
333 | BuildRemoveDeleterFix(const CXXConstructExpr *Ctor, SourceManager &SM,
| ^~~~~~~~~~~~~~~~~~~~~
| buildRemoveDeleterFix
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:338:3:
warning: variable 'Arg0End' of type 'SourceLocation' can be declared 'const'
[misc-const-correctness]
338 | SourceLocation Arg0End =
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:340:3:
warning: variable 'Arg1End' of type 'SourceLocation' can be declared 'const'
[misc-const-correctness]
340 | SourceLocation Arg1End =
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:379:8:
warning: static member accessed through instance
[readability-static-accessed-through-instance]
379 | if (!Ctx.hasSameType(AllocTy.getCanonicalType().getUnqualifiedType(),
| ^~~~
| clang::ASTContext::
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:383:3:
warning: variable 'DelPointee' of type 'QualType' can be declared 'const'
[misc-const-correctness]
383 | QualType DelPointee = GetDeleterParamPointee(Ctor->getArg(1));
| ^
| const
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:386:8:
warning: static member accessed through instance
[readability-static-accessed-through-instance]
386 | if
(!Ctx.hasSameType(DelPointee.getCanonicalType().getUnqualifiedType(),
| ^~~~
| clang::ASTContext::
clang-tools-extra/clang-tidy/modernize/UseSharedPtrArrayCheck.cpp:428:8:
warning: invalid case style for variable 'warn' [readability-identifier-naming]
428 | auto warn = [&]() -> DiagnosticBuilder {
| ^~~~
| Warn
429 | return diag(Ctor->getBeginLoc(),
430 | "use 'std::shared_ptr<%0[]>' instead of "
431 | "'std::shared_ptr<%0>' with explicit array deleter")
432 | << WrittenType.str();
433 | };
434 |
435 | // Multi-declarator: one TypeLoc shared across all declarators. Warn
only.
436 | if (ParentVD) {
437 | const auto &VDParents = Ctx.getParents(*ParentVD);
438 | if (!VDParents.empty())
439 | if (const auto *DS = VDParents[0].get<DeclStmt>())
440 | if (!DS->isSingleDecl()) {
441 | warn();
| ~~~~
| Warn
```
</details>
https://github.com/llvm/llvm-project/pull/199458
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
