Andres-Salamanca wrote: In that case we could keep the brackets as @erichkeane mentioned they stick out nicely, drop the commas between flags and use `oilist` as @xlauko suggested, and also move the alignment out of the attr-dict to make it look closer to `llvm.alloca` as @andykaylor suggested and consistent with `cir.store`: ```mlir %0 = cir.alloca !s32i, !cir.ptr<!s32i>, align(4) ["n" init const] ``` does that look good to all of you or do you have other suggestions?
https://github.com/llvm/llvm-project/pull/198962 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
