================
@@ -452,19 +452,35 @@ bool SemaAMDGPU::checkAtomicOrderingCABIArg(Expr *E, bool
MayLoad,
return false;
}
-bool SemaAMDGPU::checkCoopAtomicFunctionCall(CallExpr *TheCall, bool IsStore) {
- bool Fail = false;
-
- // First argument is a global or generic pointer.
+// Check that the first argument to TheCall is a global or generic pointer.
+static bool checkGlobalOrFlatPointerArg(SemaAMDGPU &S, CallExpr *TheCall) {
Expr *PtrArg = TheCall->getArg(0);
QualType PtrTy = PtrArg->getType()->getPointeeType();
- unsigned AS = getASTContext().getTargetAddressSpace(PtrTy.getAddressSpace());
+ unsigned AS =
+ S.getASTContext().getTargetAddressSpace(PtrTy.getAddressSpace());
if (AS != llvm::AMDGPUAS::FLAT_ADDRESS &&
- AS != llvm::AMDGPUAS::GLOBAL_ADDRESS) {
- Fail = true;
- Diag(TheCall->getBeginLoc(), diag::err_amdgcn_coop_atomic_invalid_as)
- << PtrArg->getSourceRange();
- }
+ AS != llvm::AMDGPUAS::GLOBAL_ADDRESS)
+ return S.Diag(TheCall->getBeginLoc(),
+ diag::err_amdgcn_global_or_flat_pointer_required)
+ << PtrArg->getSourceRange();
----------------
shiltian wrote:
```suggestion
AS != llvm::AMDGPUAS::GLOBAL_ADDRESS) {
return S.Diag(TheCall->getBeginLoc(),
diag::err_amdgcn_global_or_flat_pointer_required)
<< PtrArg->getSourceRange();
}
```
https://llvm.org/docs/AMDGPU/DeveloperGuideline.html#use-of-braces
https://github.com/llvm/llvm-project/pull/199175
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
