================
@@ -194,7 +194,8 @@ cir::RecordType 
clang::CIRGen::CIRGenBuilderTy::getCompleteRecordType(
   if (name.empty())
     return getAnonRecordTy(members, packed, padded);
 
-  return getCompleteNamedRecordType(members, packed, padded, name);
+  return getCompleteNamedRecordType(members, packed, padded, mlir::Type{},
----------------
erichkeane wrote:

This feels problematic/difficult to read why we are just passing a plain `type` 
there for seemingly no reason.

Rather than this taking the padding TYPE, should it take the padding size and 
generate it? Alternatively, should this take some sort of `PaddingInfo` object, 
such that th is would take: `PaddingInfo::None` object? 

https://github.com/llvm/llvm-project/pull/198423
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to