https://github.com/smithp35 commented:
I've added a couple more people that have reviewed driver patches. Unfortunately I don't think there's a MIPS maintainer in LLVM anymore so we tend to struggle in this area (https://discourse.llvm.org/t/mips-maintainer/88209) The code to enable the driver to function with Mips looks fine. This will need some tests. A good place to start looking is in `clang/test/Driver` to see how the driver tests are structured. For example see aarch64-toolchain.c with target aarch64-none-elf. As mentioned previously we are lacking a MIPS maintainer and we may not have anyone able to test on MIPS hardware. The tests will need to capture the behaviour you need from the Driver, otherwise support can easily bitrot. https://github.com/llvm/llvm-project/pull/196322 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
