https://github.com/AaronBallman requested changes to this pull request.
This has been a default error since 2011 (https://github.com/llvm/llvm-project/commit/254a5c07e7c96) and I question why we'd want to make it a hard error 15 years later. There's evidence that this diagnostic is disabled in practice: https://sourcegraph.com/search?q=context:global+-Wno-non-pod-varargs+-file:.*test.*&patternType=keyword&sm=0 I think the correct approach is to fix the crash, not to make this a hard error. There are non-POD types for which this is still reasonable: https://godbolt.org/z/sEcnez9jd https://github.com/llvm/llvm-project/pull/198668 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
