================
@@ -306,6 +306,19 @@ equalAttrArgs(T A1, T A2, StructuralEquivalenceContext 
&Context) {
   return A1 == A2;
 }
 
+// ParamIdx has an explicit specialization because it can be invalid (when
+// representing an optional parameter that was not specified).  Two invalid
+// ParamIdx values compare equal; an invalid value is not equal to any valid
+// one.  ParamIdx::operator== asserts both sides are valid, so we must guard
----------------
melver wrote:

function-level comments should explain what the function does. This is 
explaining the implementation of the function. This is fine, but should be 
moved inside to document the implementation.

https://github.com/llvm/llvm-project/pull/199980
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to