================
@@ -1881,15 +1881,47 @@ Sema::ConditionResult 
Parser::ParseCXXCondition(StmtResult *InitStmt,
   }
 
   ParsedAttributes attrs(AttrFactory);
-  MaybeParseCXX11Attributes(attrs);
+  bool ParsedAttrs = MaybeParseCXX11Attributes(attrs);
----------------
AaronBallman wrote:

> I believe __attribute__(()) is a GNU attribute, that's why it makes sense 
> that GCC parses these.

It's also an extension Clang supports.

> However, the paper clearly states that the allowed attributes are C23 
> attributes only.

Extensions are outside of what the standard will talk about.

> There would be no point of deviating from the wording of the paper, even when 
> we are allowing this feature in old language modes.

We're not deviating from the wording in the paper, we're supporting extensions 
we support elsewhere. Otherwise we should not implement `__attribute__` 
anywhere because the standard doesn't mention the construct.


https://github.com/llvm/llvm-project/pull/198244
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to