https://github.com/xlauko commented:

Thanks for cleaning this up :)

I would suggest, in similar manner to `mlir/include/mlir/InitAllDialects.h`, to 
put this in `clang/include/clang/CIR/InitAllDialects.h` as it is not really 
dialect header. And maybe eventually we will have more `CIR` dialects.

Also might be worth adding another convenience overload 

```
void registerAllDialects(DialectRegistry &registry);
void registerAllDialects(MLIRContext &context);  // convenience overload
```

https://github.com/llvm/llvm-project/pull/200266
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to