github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
clang/test/Lexer/dollar-macros.cpp clang/include/clang/Basic/IdentifierTable.h
clang/include/clang/Lex/Lexer.h clang/include/clang/Lex/Preprocessor.h
clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Lex/Lexer.cpp
clang/lib/Lex/Preprocessor.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp
b/clang/lib/Driver/ToolChains/Clang.cpp
index de8e89ca0..7657afb14 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -7855,8 +7855,6 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
CmdArgs.push_back("-fno-dollars-in-identifiers");
}
-
-
Args.addOptInFlag(CmdArgs, options::OPT_fapple_pragma_pack,
options::OPT_fno_apple_pragma_pack);
diff --git a/clang/lib/Lex/Lexer.cpp b/clang/lib/Lex/Lexer.cpp
index b0266f21a..57f4b4807 100644
--- a/clang/lib/Lex/Lexer.cpp
+++ b/clang/lib/Lex/Lexer.cpp
@@ -2023,7 +2023,7 @@ bool Lexer::LexIdentifierContinue(Token &Result, const
char *CurPtr,
if (C == '$') {
// If we hit a $ and they are not supported in macros, we are done.
if (!LangOpts.DollarMacros)
- break;
+ break;
// Otherwise, emit a diagnostic and continue.
if (!isLexingRawMode())
Diag(CurPtr, diag::ext_dollar_in_identifier);
``````````
</details>
https://github.com/llvm/llvm-project/pull/200614
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
