llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) <details> <summary>Changes</summary> from `Pointer::toAPValue()`. --- Full diff: https://github.com/llvm/llvm-project/pull/200789.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Pointer.cpp (-4) - (modified) clang/test/SemaCXX/constant-expression-p2280r4.cpp (+2-4) ``````````diff diff --git a/clang/lib/AST/ByteCode/Pointer.cpp b/clang/lib/AST/ByteCode/Pointer.cpp index 93357653c6f5d..96409faeb6929 100644 --- a/clang/lib/AST/ByteCode/Pointer.cpp +++ b/clang/lib/AST/ByteCode/Pointer.cpp @@ -214,10 +214,6 @@ APValue Pointer::toAPValue(const ASTContext &ASTCtx) const { } else llvm_unreachable("Invalid allocation type"); - if (isUnknownSizeArray()) - return APValue(Base, CharUnits::Zero(), Path, - /*IsOnePastEnd=*/isOnePastEnd(), /*IsNullPtr=*/false); - CharUnits Offset = CharUnits::Zero(); auto getFieldOffset = [&](const FieldDecl *FD) -> CharUnits { diff --git a/clang/test/SemaCXX/constant-expression-p2280r4.cpp b/clang/test/SemaCXX/constant-expression-p2280r4.cpp index 649ed41ca58c4..8b768f42d1260 100644 --- a/clang/test/SemaCXX/constant-expression-p2280r4.cpp +++ b/clang/test/SemaCXX/constant-expression-p2280r4.cpp @@ -285,11 +285,9 @@ namespace unsized_array { void f(int (&a)[], int (&b)[], int (&c)[4]) { constexpr int t1 = a - a; constexpr int t2 = a - b; // expected-error {{constexpr variable 't2' must be initialized by a constant expression}} \ - // nointerpreter-note {{arithmetic involving unrelated objects '&a[0]' and '&b[0]' has unspecified value}} \ - // interpreter-note {{arithmetic involving unrelated objects '&a' and '&b' has unspecified value}} + // expected-note {{arithmetic involving unrelated objects '&a[0]' and '&b[0]' has unspecified value}} constexpr int t3 = a - &c[2]; // expected-error {{constexpr variable 't3' must be initialized by a constant expression}} \ - // nointerpreter-note {{arithmetic involving unrelated objects '&a[0]' and '&c[2]' has unspecified value}} \ - // interpreter-note {{arithmetic involving unrelated objects '&a' and '&c[2]' has unspecified value}} + // expected-note {{arithmetic involving unrelated objects '&a[0]' and '&c[2]' has unspecified value}} } } `````````` </details> https://github.com/llvm/llvm-project/pull/200789 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
