github-actions[bot] wrote:
<!--LLVM CODE LINT COMMENT: clang-tidy-->
:warning: C/C++ code linter, clang-tidy found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
```bash
git diff -U0 origin/main...HEAD --
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp
clang-tools-extra/clang-tidy/tool/ClangTidyMain.h
clang-tools-extra/clang-tidy/tool/ClangTidyToolMain.cpp |
python3 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py -path build -p1
-quiet
```
</details>
<details>
<summary>
View the output from clang-tidy here.
</summary>
```
clang-tools-extra/clang-tidy/tool/ClangTidyToolMain.cpp:20:5: warning: function
'clang_tidy_main' can be made static or moved into an anonymous namespace to
enforce internal linkage [misc-use-internal-linkage]
20 | int clang_tidy_main(int argc, char **argv, const llvm::ToolContext &) {
| ^
| static
clang-tools-extra/clang-tidy/tool/ClangTidyToolMain.cpp:20:5: warning: invalid
case style for function 'clang_tidy_main' [readability-identifier-naming]
20 | int clang_tidy_main(int argc, char **argv, const llvm::ToolContext &) {
| ^~~~~~~~~~~~~~~
| clangTidyMain
clang-tools-extra/clang-tidy/tool/ClangTidyToolMain.cpp:20:25: warning: invalid
case style for parameter 'argc' [readability-identifier-naming]
20 | int clang_tidy_main(int argc, char **argv, const llvm::ToolContext &) {
| ^~~~
| Argc
21 | return clang::tidy::clangTidyMain(argc, argv);
| ~~~~
| Argc
clang-tools-extra/clang-tidy/tool/ClangTidyToolMain.cpp:20:38: warning: invalid
case style for parameter 'argv' [readability-identifier-naming]
20 | int clang_tidy_main(int argc, char **argv, const llvm::ToolContext &) {
| ^~~~
| Argv
21 | return clang::tidy::clangTidyMain(argc, argv);
| ~~~~
| Argv
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:26:1: warning: included
header StringSwitch.h is not used directly [misc-include-cleaner]
26 | #include "llvm/ADT/StringSwitch.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
27 | #include "llvm/Option/Arg.h"
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:51:10: error: 'Opts.inc'
file not found [clang-diagnostic-error]
51 | #include "Opts.inc"
| ^~~~~~~~~~
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:71:3: warning: use '=
default' to define a trivial default constructor [modernize-use-equals-default]
71 | ClangTidyOptTable()
| ^
72 | : opt::GenericOptTable(OptionStrTable, OptionPrefixesTable,
InfoTable) {}
|
~~
|
= default;
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:202:13: warning: place
static function 'printHelp' outside of an anonymous namespace
[llvm-prefer-static-over-anonymous-namespace]
202 | static void printHelp(bool ShowHidden = false) {
| ^
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:203:3: warning: variable
'Tbl' of type 'ClangTidyOptTable' can be declared 'const'
[misc-const-correctness]
203 | ClangTidyOptTable Tbl;
| ^
| const
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:211:13: warning: place
static function 'parseBoolArg' outside of an anonymous namespace
[llvm-prefer-static-over-anonymous-namespace]
211 | static bool parseBoolArg(const opt::Arg *A, unsigned ValueID, bool
&Value) {
| ^
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:231:13: warning: place
static function 'parseBoolArg' outside of an anonymous namespace
[llvm-prefer-static-over-anonymous-namespace]
231 | static bool parseBoolArg(const opt::InputArgList &Args, unsigned FlagID,
| ^
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:241:13: warning: place
static function 'parseCommandLine' outside of an anonymous namespace
[llvm-prefer-static-over-anonymous-namespace]
241 | static bool parseCommandLine(int argc, char **argv, BumpPtrAllocator
&Allocator,
| ^
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:241:34: warning: invalid
case style for parameter 'argc' [readability-identifier-naming]
241 | static bool parseCommandLine(int argc, char **argv, BumpPtrAllocator
&Allocator,
| ^~~~
| Argc
242 | StringSaver &Saver, ClangTidyOptTable &Tbl,
243 | opt::InputArgList &Args,
244 | std::unique_ptr<CompilationDatabase>
&Compilations,
245 | std::vector<std::string> &SourcePaths) {
246 | SmallVector<const char *> ExpandedArgs(argv, argv + argc);
| ~~~~
| Argc
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:241:47: warning: invalid
case style for parameter 'argv' [readability-identifier-naming]
241 | static bool parseCommandLine(int argc, char **argv, BumpPtrAllocator
&Allocator,
| ^~~~
| Argv
242 | StringSaver &Saver, ClangTidyOptTable &Tbl,
243 | opt::InputArgList &Args,
244 | std::unique_ptr<CompilationDatabase>
&Compilations,
245 | std::vector<std::string> &SourcePaths) {
246 | SmallVector<const char *> ExpandedArgs(argv, argv + argc);
| ~~~~ ~~~~
| Argv Argv
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:615:3: warning: variable
'Saver' of type 'StringSaver' can be declared 'const' [misc-const-correctness]
615 | StringSaver Saver(Alloc);
| ^
| const
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:616:3: warning: variable
'Tbl' of type 'ClangTidyOptTable' can be declared 'const'
[misc-const-correctness]
616 | ClangTidyOptTable Tbl;
| ^
| const
clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:617:3: warning: variable
'Args' of type 'opt::InputArgList' can be declared 'const'
[misc-const-correctness]
617 | opt::InputArgList Args;
| ^
| const
```
</details>
https://github.com/llvm/llvm-project/pull/201743
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
