https://github.com/steffenlarsen requested changes to this pull request.
Hi @clearnature! Thank you for submitting this! Before we go any further, could you please revisit the changes and split it into more digestable patches? A few initial comments: - Unrelated fixes, like the one in compiler-rt should be its own PR. - Avoid making unrelated NFC changes, like the newline in clang-tools-extra. - I'm not sure it's a general rule, but please add a newline at the end of the new files. - I think you kept in some files and changes that weren't supposed to be included in this, such as the python scripts with hardcoded paths, the binary files, the changes to .gitignore, etc. - Adding documentation is awesome and I appreciate you adding it immediately, but could you please rewrite it in English? https://github.com/llvm/llvm-project/pull/201734 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
