[clang-tools-extra] [clang-tidy] Fix `altera-id-dependent-backward-branch` false positives (PR #200660)

[Zeyi Xu via cfe-commits]

================
@@ -64,6 +95,31 @@ void error() {
     accumulator++;
   }
 
+  struct {
+    int FieldFromVar;
+    int FieldFromField;
+  } InferredField;
+  InferredField.FieldFromVar = ThreadID * 2;
+  while (j < InferredField.FieldFromVar) {
+    // CHECK-NOTES: :[[@LINE-1]]:10: warning: backward branch (while loop) is 
ID-dependent due to member reference to 'FieldFromVar' and may cause 
performance degradation [altera-id-dependent-backward-branch]
+    // CHECK-NOTES: :[[@LINE-6]]:5: note: inferred assignment of ID-dependent 
member from ID-dependent variable ThreadID
+    accumulator++;
+  }
+
+  InferredField.FieldFromField = Example.IDDepField;
+  while (j < InferredField.FieldFromField) {
+    // CHECK-NOTES: :[[@LINE-1]]:10: warning: backward branch (while loop) is 
ID-dependent due to member reference to 'FieldFromField' and may cause 
performance degradation [altera-id-dependent-backward-branch]
+    // CHECK-NOTES: :[[@LINE-12]]:5: note: inferred assignment of ID-dependent 
member from ID-dependent member IDDepField
----------------
zeyi2 wrote:

I'm fine with leaving it for a separate PR. Then current implementation LGTM 
after fixing CI failure (line offset needs simple adjustments).

https://github.com/llvm/llvm-project/pull/200660
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits