llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-backend-systemz Author: Zibi Sarbinowski (zibi2) <details> <summary>Changes</summary> # Refactor: Rename GetSingleElementType to getSingleElementType in SystemZ ABI ## Summary This PR refactors the SystemZ ABI code to follow LLVM coding standards by renaming `GetSingleElementType` to `getSingleElementType` (camelCase convention). ## Changes - Renamed method declaration in `SystemZABIInfo` class - Fixed `ZOSXPLinkABIInfo::getSingleElementType` to use `getAsRecordDecl()` instead of `getDecl()` for correctness and consistency wiith `SystemZABIInfo`. ## Motivation Rename to avoid having 'GetSingleElementType` in one class and `getSingleElementType` in another one. --- Full diff: https://github.com/llvm/llvm-project/pull/203078.diff 1 Files Affected: - (modified) clang/lib/CodeGen/Targets/SystemZ.cpp (+7-7) ``````````diff diff --git a/clang/lib/CodeGen/Targets/SystemZ.cpp b/clang/lib/CodeGen/Targets/SystemZ.cpp index 5c7485ed0944f..9cffc67dd85b5 100644 --- a/clang/lib/CodeGen/Targets/SystemZ.cpp +++ b/clang/lib/CodeGen/Targets/SystemZ.cpp @@ -32,7 +32,7 @@ class SystemZABIInfo : public ABIInfo { bool isCompoundType(QualType Ty) const; bool isVectorArgumentType(QualType Ty) const; llvm::Type *getFPArgumentType(QualType Ty, uint64_t Size) const; - QualType GetSingleElementType(QualType Ty) const; + QualType getSingleElementType(QualType Ty) const; ABIArgInfo classifyReturnType(QualType RetTy) const; ABIArgInfo classifyArgumentType(QualType ArgTy) const; @@ -207,7 +207,7 @@ llvm::Type *SystemZABIInfo::getFPArgumentType(QualType Ty, return nullptr; } -QualType SystemZABIInfo::GetSingleElementType(QualType Ty) const { +QualType SystemZABIInfo::getSingleElementType(QualType Ty) const { const auto *RD = Ty->getAsRecordDecl(); if (RD && RD->isStructureOrClass()) { QualType Found; @@ -224,7 +224,7 @@ QualType SystemZABIInfo::GetSingleElementType(QualType Ty) const { if (!Found.isNull()) return Ty; - Found = GetSingleElementType(Base); + Found = getSingleElementType(Base); } // Check the fields. @@ -241,7 +241,7 @@ QualType SystemZABIInfo::GetSingleElementType(QualType Ty) const { // Nested structures still do though. if (!Found.isNull()) return Ty; - Found = GetSingleElementType(FD->getType()); + Found = getSingleElementType(FD->getType()); } // Unlike isSingleElementStruct(), trailing padding is allowed. @@ -439,7 +439,7 @@ ABIArgInfo SystemZABIInfo::classifyArgumentType(QualType Ty) const { // as opposed to float-like structure types, we do not allow any // padding for vector-like structures, so verify the sizes match. uint64_t Size = getContext().getTypeSize(Ty); - QualType SingleElementTy = GetSingleElementType(Ty); + QualType SingleElementTy = getSingleElementType(Ty); if (isVectorArgumentType(SingleElementTy) && getContext().getTypeSize(SingleElementTy) == Size) return ABIArgInfo::getDirect(CGT.ConvertType(SingleElementTy)); @@ -506,7 +506,7 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, // be passed via "hidden" pointer where any extra alignment is not // required (per GCC). const Type *SingleEltTy = getABIInfo<SystemZABIInfo>() - .GetSingleElementType(QualType(Ty, 0)) + .getSingleElementType(QualType(Ty, 0)) .getTypePtr(); bool SingleVecEltStruct = SingleEltTy != Ty && SingleEltTy->isVectorType() && Ctx.getTypeSize(SingleEltTy) == Ctx.getTypeSize(Ty); @@ -648,7 +648,7 @@ QualType ZOSXPLinkABIInfo::getSingleElementType(QualType Ty) const { if (const RecordType *RT = Ty->getAsUnionType()) { QualType Found; // Check the fields. - const RecordDecl *RD = RT->getDecl(); + const RecordDecl *RD = RT->getAsRecordDecl(); for (const auto *FD : RD->fields()) { if (Found.isNull()) Found = getSingleElementType(FD->getType()); `````````` </details> https://github.com/llvm/llvm-project/pull/203078 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
