HighCommander4 wrote:

> Can you explain why we need a test in clangd?

I can explain this part: as described in [this 
comment](https://github.com/llvm/llvm-project/issues/185108#issuecomment-4021021907),
 clang-tidy's infrastructure does some post-processing of the checker results 
in `DiagnosticRenderer` which hides the deficiency in the checker; clangd does 
not do such post-processing.

The test looks good to me, but I'll leave it up to @vbvictor to say whether the 
fix approach in the checker implementation is the desired one.




https://github.com/llvm/llvm-project/pull/202365
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to