github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp --
clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/TypeBase.h
clang/include/clang/Sema/SemaHLSL.h clang/lib/AST/Expr.cpp
clang/lib/AST/Type.cpp clang/lib/CodeGen/CGExprAgg.cpp
clang/lib/CodeGen/CGHLSLRuntime.cpp
clang/lib/Sema/HLSLBuiltinTypeDeclBuilder.cpp clang/lib/Sema/SemaExpr.cpp
clang/lib/Sema/SemaHLSL.cpp clang/lib/Sema/SemaInit.cpp
clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaTemplateInstantiate.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/include/clang/AST/DeclCXX.h
b/clang/include/clang/AST/DeclCXX.h
index 28d171253..06e5f2db6 100644
--- a/clang/include/clang/AST/DeclCXX.h
+++ b/clang/include/clang/AST/DeclCXX.h
@@ -763,16 +763,16 @@ public:
/// this class.
///
/// This value is used for lazy creation of default constructors.
- bool needsImplicitDefaultConstructor() const {
+ bool needsImplicitDefaultConstructor() const {
return (!getLangOpts().HLSL || isHLSLBuiltinRecord()) &&
((!data().UserDeclaredConstructor &&
- !(data().DeclaredSpecialMembers & SMF_DefaultConstructor) &&
- (!isLambda() || lambdaIsDefaultConstructibleAndAssignable())) ||
- // FIXME: Proposed fix to core wording issue: if a class inherits
- // a default constructor and doesn't explicitly declare one, one
- // is declared implicitly.
- (data().HasInheritedDefaultConstructor &&
- !(data().DeclaredSpecialMembers & SMF_DefaultConstructor)));
+ !(data().DeclaredSpecialMembers & SMF_DefaultConstructor) &&
+ (!isLambda() || lambdaIsDefaultConstructibleAndAssignable())) ||
+ // FIXME: Proposed fix to core wording issue: if a class inherits
+ // a default constructor and doesn't explicitly declare one, one
+ // is declared implicitly.
+ (data().HasInheritedDefaultConstructor &&
+ !(data().DeclaredSpecialMembers & SMF_DefaultConstructor)));
}
/// Determine whether this class has any user-declared constructors.
@@ -896,8 +896,7 @@ public:
(!getLangOpts().HLSL || isHLSLBuiltinRecord()) &&
!hasUserDeclaredCopyConstructor() &&
!hasUserDeclaredCopyAssignment() &&
- !hasUserDeclaredMoveAssignment() &&
- !hasUserDeclaredDestructor();
+ !hasUserDeclaredMoveAssignment() && !hasUserDeclaredDestructor();
}
/// Determine whether we need to eagerly declare a defaulted move
@@ -989,8 +988,7 @@ public:
(!getLangOpts().HLSL || isHLSLBuiltinRecord()) &&
!hasUserDeclaredCopyConstructor() &&
!hasUserDeclaredCopyAssignment() &&
- !hasUserDeclaredMoveConstructor() &&
- !hasUserDeclaredDestructor() &&
+ !hasUserDeclaredMoveConstructor() && !hasUserDeclaredDestructor() &&
(!isLambda() || lambdaIsDefaultConstructibleAndAssignable());
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/203459
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
